-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
Remove the CoroutineWitness type, follow-up to #144157
#151078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
changes to the core type system cc @lcnr This PR changes rustc_public cc @oli-obk, @celinval, @ouz-a, @makai410 Some changes occurred to the CTFE machinery Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri Some changes occurred in exhaustiveness checking cc @Nadrieril Some changes occurred in src/tools/clippy cc @rust-lang/clippy Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt Some changes occurred in compiler/rustc_sanitizers cc @rcvalle |
|
rustbot has assigned @WaffleLapkin. Use |
|
r? @compiler-errors |
|
Failed to set assignee to
|
|
I don’t work on Rust anymore unfortunately. r? lcnr |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
hi, thanks for picking this up, but i guess it wasn't finished back then for some reason, and it seems to me because of exactly same problem that your pr hit here with overflow evaluating so it seems like this problem is more complex and im not really sure if that's a good first issue (don't get me wrong i'm not trying to discourage you on this) |
|
☔ The latest upstream changes (presumably #151144) made this pull request unmergeable. Please resolve the merge conflicts. |
|
The remaining work is quite technically involved #144157 (comment). @BoxyUwU is currently looking into introducing where-bounds on binders in general, which will supersede this. Alternatively, we can finish this once the new trait solver is stable #107374 |
|
Thank you for trying to continue this work. |
Based upon the work in #144157. Last commit says
Anyone is welcome to pick this back up.I hope I understood correctly and effort/time to rebase was the blocker on that PR. My first PR on rust-lang - so let me know if I could've done something better.